[MPlayer-dev-eng] [PATCH] channel reordering for 6ch audio

[Alexander 'Lazy Ranma' Ponyatikh]

> The channels seem to be in interleaved order (I didn't pay attention to
> that the last time). Using memcpy to copy individual samples is very
> inefficient, as would anything that calls a function for each sample.
> This is true for the other patches too.

Ok. I'll see what can be done later tonight. The problem is that the
sample can be 1 to 4 bytes long, so I either have to copy samples byte
by byte or make individual code for each sample size.

> Also I think you should return a
> multiple of samplesize*channels; returning "read" doesn't make sense if
> any partial results are reordered so that the caller can't even know
> which bytes are actually read and which undefined (though this'll
> probably change anyway if it's rewritten in a more efficient way).

Actually, this can only happen at the end of trimmed wav/pcm file,
and I doubt, that audio driver would try to play half of sample... But
I'll change it.





-- 
С уважением,
 Alexander                          mailto:ranma at 274.ru