[MPlayer-dev-eng] non-free and undistributable files in tremor/

[Roberto Togni]

On Sun, 30 Jul 2006 02:51:50 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> Bad news everyone!
> 
> In the tremor/ subdirectory we have 15 (!) files, namely
> 
>   backends.h
>   block.c
>   codebook.c
>   codebook.h
>   codec_internal.h
>   info.c
>   ivorbiscodec.h
>   lsp_lookup.h
>   mapping0.c
>   os.h
>   registry.c
>   registry.h
>   res012.c
>   sharedbook.c
>   synthesis.c
> 
[...]

You can get all those files with a correct bsd license header from
tremor svn (http://svn.xiph.org/trunk/Tremor) by checking out r3895.
The previous version r3890 contains the same files with the bad license
header.
Except from the headers the only difference between our files and the
ones from r3895 is in sharedbook.c

@@ -208,7 +211,7 @@
          int indexdiv=1;
          for(k=0;k<b->dim;k++){
            int index= (j/indexdiv)%quantvals;
-           ogg_int32_t point;
+           int point;
            int val=VFLOAT_MULTI(delta,delpoint,
                                 abs(b->quantlist[index]),&point);

@@ -242,7 +245,7 @@
          int         lastpoint=0;

          for(k=0;k<b->dim;k++){
-           ogg_int32_t point;
+           int point;
            int val=VFLOAT_MULTI(delta,delpoint,
                                 abs(b->quantlist[j*b->dim+k]),&point);


We probably have to commit also this change to be on the safe side.

The error was probably getting the files from the 1.0 release
instead of the svn repository, but those files were already available
for public download whit a correct license header when the code was
committed to MPlayer cvs.

Ciao,
 Roberto