[MPlayer-dev-eng] [PATCH] Audio support for AVISynth

[Alexander 'Lazy Ranma' Ponyatikh]

>> > You only added a few spaces here, please, if you move it to a seperate
>> > patch everyone will have a much easier time to understand what this
>> > patch actually does, what it changes and why it didn't work before (or
>> > in other words, learn from it).
>> No, this block of code has been moved into new if statement.
> I.e. it mixed cosmetics and "real" changes.
> DOCS/tech/patches.txt explains our policy regarding patches.

So, should I make a patch with "if (...) { <old_code> }" first, then
make a separate patch, which add spaces to <old_code>?

>> >> +        AVS->frameno++;
>> >> +        AVS->avs_release_video_frame(curr_frame);
>> > Why were these two lines moved up? Is this necessary for the audio
>> > support to work or is this a seperate issue or just "cosmetic"?
>> It is necessary. They have been moved inside "if
>> (avs_has_video(AVS->video_info) && (ds == demuxer->video))" statement.
> Ok, not cosmetic. Though it doesn't seem directly related to audio
> support. Anyway, I applied that part with cosmetics and real changes
> split properly (well, the sh_video variable still needs to be moved in a
> later patch).

Actually, it's related to audio support. It prevents skipping of video
frame when audio is requested. W/o it scripts w/ audio will be
unplayable.