[MPlayer-dev-eng] Re: [PATCH] fix stack usage in libvo/font_load_ft.c

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Jul 25 16:02:48 CEST 2006


Hello,
On Fri, Jul 21, 2006 at 08:44:31PM +0000, Tobias Diedrich wrote:
> Alternative version, uses goto to avoid duplicated free calls.
> I also forgot to check for malloc failure in the previous version.

Fine with me, though I'd prefer a little change:
initialize desc to NULL, always doing goto err_out
and checking for desc != NULl there and freeing if needed.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list