[MPlayer-dev-eng] [PATCH] Windows DLL support for OS X/Intel

[Reimar Döffinger]

Hello,
On Sun, Jul 23, 2006 at 07:51:12PM +0300, Valtteri Vuorikoski wrote:
> I have patched the svn-trunk version of mplayer to support Windows DLL
> codecs on MacOS X (Intel).

How does this relate to http://bugzilla.mplayerhq.hu/show_bug.cgi?id=514
?

> IMPORTANT: You _must_ define the environment variable DYLD_BIND_AT_LAUNCH
> for the DLL codecs to work (ie. "DYLD_BIND_AT_LAUNCH=1 ./mplayer foo.wmv").
> Otherwise mplayer crashes when dyld tries to bind functions while running
> inside win32 compatibility functions.

Looks like this is the issue that "caused" all those large patches in
the URL above *g*

> - The anonymous mmap() stuff with #ifdef __APPLE__ is silly. A generic
> mmap-wrapper would probably be nice. Is there a reason why FILE_dommap
> isn't used everywhere in ext.c?

IMHO requiring anonymous mmap is fine (but make sure to accept both
MAP_ANON and MAP_ANONYMOUS as libswscale/swscale.c does).
If some OS does not support it, it should be emulated via a stub in osdep or so.
Though using FILE_dommap everywhere would be a possibility, too, but it
should be cleaned up before, e.g. the flags parameter is completely
ignored...

Greetings,
Reimar Döffinger