[MPlayer-dev-eng] [PATCH/RFC] libswscale using mmx even when disabled by configure

[Diego Biurrun]

On Wed, Jul 19, 2006 at 01:13:43AM -0400, Rich Felker wrote:
> while testing just now, i discovered that 3 files in libswscale try to
> assemble mmx code even when mmx is explicitly disabled. they're
> wrongly using ARCH_X86[_64] defines instead of HAVE_{MMX|MMX2|3DNOW}
> to decide what to compile. i was having trouble sorting through all
> the ifdef mess so i just undefined ARCH_X86 when mmx, mmx2, and 3dnow
> are all disabled. this is not really a clean fix though.

Hey, there are much worse files ;-p

Why not check for HAVE_MMX (or whatever it's called) instead?  It's a
few more checks, but it's the only way to be correct.

> on the other hand, what about having a global --disable-asm or
> --disable-arch option in the configure script to disable the setting
> of the ARCH_* defines entirely?

If you find it useful, go ahead and implement it...

Diego