[MPlayer-dev-eng] [PATCH] PulseAudio audio output

[Reimar Döffinger]

Hello,
On Sun, Jul 16, 2006 at 03:18:59PM +0200, Lennart Poettering wrote:
> As some of you probably noticed the Polypaudio project was recently
> renamed to PulseAudio. The following patch renames MPlayer's ao_polyp
> driver to ao_pulse and updates it for the recent PulseAudio API changes:

I am not at all a fan of senseless renames I must say. And what kind of
API changes? Will it no longer work with older versions? And how old are
the versions it would break?

> http://0pointer.de/public/mplayer-pulse.patch

That's impossible to review, it doesn't show what exactly you changed.
You should have used e.g. svn move to create libao2/ao_pulse.c.
Also attaching patches is very much preferred.

> Some other changes have been made as well:

Cosmetics (such as renaming) and other stuff must be a separate patch.

> * The PulseAudio client runs its event loop in a thread of its
>   own. This should make PulseAudio's latency interpolation over the
>   network much more reliable.

Judging by the number of pa_threaded_mainloop* stuff this was not
exactly introduced in a transparent way. Isn't there an API that gets
away with a bit less locking and provides a synchronous API?
Having things like this:
+    while (pa_operation_get_state(o) != PA_OPERATION_DONE) {
+        CHECK_DEAD_GOTO(fail);
+        pa_threaded_mainloop_wait(mainloop);
+    }

all over the place is not beautiful.

> * Proper surround sound support

Should be a separate patch as well (unless it is directly connected to
the new API).

Greetings,
Reimar Döffinger