[MPlayer-dev-eng] [PATCH] remove opendivx/divx4 support

Diego Biurrun diego at biurrun.de
Sat Jul 15 16:38:07 CEST 2006


On Fri, Jul 14, 2006 at 09:31:17PM -0400, Rich Felker wrote:
> On Fri, Jul 14, 2006 at 10:41:34PM +0200, Michael Niedermayer wrote:
> > in the past being able to try many different decoders was usefull to
> > debug and improve lavc, now that lavcs mpeg4 decoder is pretty much bugfree
> > the loss of -vd divx4 will probably have little if any effect but still
> 
> Agree. IMO the main effect is that it means less modules that need to
> be updated when we fix the vd/vf layer to support pts, etc. better,
> and this is a good thing because it means fixing longstanding
> brokenness is easier.

I fully agree.  We should not keep cruft around just because of inertia.
At some points in time we need to reevaluate stuff and get rid of cruft
to keep the codebase healthy.

> > i agree with roberto here that the removial was too quick without giving
> > people a chance to comment
> 
> Agree. Committing this sooner than you said was just asking for hard
> feelings, Diego. On the other hand I understand that you have tons of
> uncommitted crap in your local tree and want to get it closer to
> sync... But please hold off and give fair warning and time for
> discussion on such controversial changes.

Yes, see my reply to Roberto.

Diego



More information about the MPlayer-dev-eng mailing list