[MPlayer-dev-eng] [PATCH] remove opendivx/divx4 support
diego at biurrun.de
Sat Jul 15 16:24:35 CEST 2006
On Fri, Jul 14, 2006 at 08:20:17PM +0200, Roberto Togni wrote:
> On Fri, 14 Jul 2006 19:11:18 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> > > I agree. I'll remove this by the weekend.
> > The weekend arrived early ;) Committed ...
> As i already said in the other tread, i was against it and i'm still
> against it.
The DivX6 one? I honestly didn't remember you stating you were against
> The code not breaking anything, so there was not urgent need to remove
> it; even less to remove it before the deadline you announced.
> Most people does not live in front of their computer, so please allow a
> reasonable amount of time to discuss things, especially when you know
> in advance that the change is controversial.
Well, you *could* argue that the beginning of the weekend is somewhat
fuzzy and Friday afternoon is already the weekend. Also, I have tons of
build system changes in my local tree that get harder and harder to
separate, so I'm trying to flush them out quickly. Plus I'll be away
tomorrow for 8-9 days, possibly without internet so I wanted to stay
around a day after the commit in case some silly bug turned up.
So I had a few reasons, but with the benefit of hindsight I agree that
my commit was rushed. This thing could have waited another week without
ill effects. So yes, I rushed the commit unnecessarily. Apologies for
that, it won't happen again.
To avoid such troubles in the future I think we should set up some rules
for grace periods before commits similar to what Michael proposed
recently for FFmpeg. I'll raise the issue in a different thread.
More information about the MPlayer-dev-eng