[MPlayer-dev-eng] [PATCH] remove opendivx/divx4 support

[Rich Felker]

On Fri, Jul 14, 2006 at 10:41:34PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Fri, Jul 14, 2006 at 08:20:17PM +0200, Roberto Togni wrote:
> > On Fri, 14 Jul 2006 19:11:18 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > [...]
> > > > 
> > > > I agree.  I'll remove this by the weekend.
> > > 
> > > The weekend arrived early ;)  Committed ...
> > > 
> > 
> > As i already said in the other tread, i was against it and i'm still
> > against it.
> > The code not breaking anything, so there was not urgent need to remove
> > it; even less to remove it before the deadline you announced.
> 
> iam also not completely happy with the removial, but then again iam also
> not happy with linking GPL to non GPL code

Yes, and since we include GPL code that we did not write, I do not
think it's even legal for us to include both that imported code and
code specifically designed for linking non-free libraries together in
the repository and in our releases, unless all the copyright holders
granted us special exceptions.

> in the past being able to try many different decoders was usefull to
> debug and improve lavc, now that lavcs mpeg4 decoder is pretty much bugfree
> the loss of -vd divx4 will probably have little if any effect but still

Agree. IMO the main effect is that it means less modules that need to
be updated when we fix the vd/vf layer to support pts, etc. better,
and this is a good thing because it means fixing longstanding
brokenness is easier.

> i agree with roberto here that the removial was too quick without giving
> people a chance to comment

Agree. Committing this sooner than you said was just asking for hard
feelings, Diego. On the other hand I understand that you have tons of
uncommitted crap in your local tree and want to get it closer to
sync... But please hold off and give fair warning and time for
discussion on such controversial changes.

Rich