[MPlayer-dev-eng] [PATCH] matroska chapter seeking

[Nico Sabbi]

Evgeniy Stepanov wrote:

>On Saturday 15 July 2006 03:11, Nico Sabbi wrote:
>  
>
>>rejected; whichever form of seeking should be implemented either with
>>demux_seek()
>>    
>>
>
>You mean copypasting the whole block of code starting at mplayer.c:4922 ? The 
>one that calls resync_video_stream, audio_out->reset, set_osd_bar and so on ?
>
>What is bad with the current approach ? Regular seeking is done almost the 
>same way, the only difference is it being implemented as a command, not a 
>property.
>
>  
>

I mean the whole implementation and its strict specificity for matroska
(the same can be done with the same interface changing chapter when 
playing dvds)

>>or, since demux_seek() is already messy enough, as a DEMUXER_CTRL
>>    
>>
>
>Could you elaborate more on DEMUXER_CTRL idea ?
>  
>

#define DEMUXER_CTRL_SEEK_TO_CHAPTER 13

then in mplayer.c:

int chap = 3;

demux_control(demuxer, DEMUXER_CTRL_SEEK_TO_CHAPTER, &chap);


and something similar to obtain from the demuxer the list of available 
chapters
(according to an hypotetical chapter_t struct defined in a file 
accessible to other demuxers,
such as demuxer.h)