[MPlayer-dev-eng] [PATCH] remove opendivx/divx4 support

Diego Biurrun diego at biurrun.de
Thu Jul 13 03:27:06 CEST 2006


On Wed, Jul 12, 2006 at 12:31:59PM -0400, Rich Felker wrote:
> On Wed, Jul 12, 2006 at 03:19:07AM +0200, Diego Biurrun wrote:
> > What's the deal with divx4_vbr.[ch]?  IIUC they are not used outside of
> > divx4 and could be removed as well.  Since I still don't encode I
> > wouldn't know how to test this offhand, though ;)
> 
> It used to be used for divx, odivx, and _lavc_ before lavc had an
> internal 2pass engine. Now I doubt it's used for anything useful but I
> may be wrong. Did you examine which code calls it?

Only libmpcodecs/ve_divx4.c #includes divx4_vbr.h and the VbrControl_*
functions appear nowhere else.  So it's not used for anything and can
safely be removed as well.

Did I already mention that the divx4 encoding options are not even
documented in the man page?

Diego



More information about the MPlayer-dev-eng mailing list