[MPlayer-dev-eng] [patch] mark more string parameters as const

Stefan Huehner stefan at huehner.org
Wed Jul 12 18:02:29 CEST 2006


Hi,

attached marks several string parameters as const, when they are not
modified inside the function.

Regards,
Stefan

-------------- next part --------------
--- asxparser.c	(working copy)
+++ asxparser.c	(working copy)
@@ -92,7 +92,7 @@
 }
 
 int
-asx_attrib_to_enum(char* val,char** valid_vals) {
+asx_attrib_to_enum(const char* val,char** valid_vals) {
   char** ptr;
   int r = 0;
 
@@ -107,7 +107,7 @@
 
 static void
 asx_warning_attrib_invalid(ASX_Parser_t* parser, char* elem, char* attrib,
-			   char** valid_vals,char* val) {
+			   char** valid_vals,const char* val) {
   char *str,*vals,**ptr;
   int len;
 
--- asxparser.h	(working copy)
+++ asxparser.h	(working copy)
@@ -37,7 +37,7 @@
 asx_get_attrib(const char* attrib,char** attribs);
 
 int
-asx_attrib_to_enum(char* val,char** valid_vals);
+asx_attrib_to_enum(const char* val,char** valid_vals);
 
 #define asx_free_attribs(a) asx_list_free((void***)&a,free)
 
--- m_property.h	(working copy)
+++ m_property.h	(working copy)
@@ -120,7 +120,7 @@
 // Helpers to use MPlayer's properties
 
 /// Get an MPlayer property.
-m_option_t*  mp_property_find(char* name);
+m_option_t*  mp_property_find(const char* name);
 
 /// Do an action with an MPlayer property.
 int mp_property_do(const char* name,int action, void* val);
--- mplayer.c	(working copy)
+++ mplayer.c	(working copy)
@@ -1112,7 +1112,7 @@
  *  
  */
 
-static void set_osd_msg(int id, int level, int time, char* fmt, ...) {
+static void set_osd_msg(int id, int level, int time, const char* fmt, ...) {
     mp_osd_msg_t *msg,*last=NULL;
     va_list va;
     int r;
@@ -1243,7 +1243,7 @@
  *
  */
 
-void set_osd_bar(int type,char* name,double min,double max,double val) {
+void set_osd_bar(int type,const char* name,double min,double max,double val) {
     
     if(osd_level < 1) return;
     
@@ -2254,7 +2254,7 @@
     { NULL, NULL, NULL, 0, 0, 0, NULL }
 };
 
-m_option_t*  mp_property_find(char* name) {
+m_option_t*  mp_property_find(const char* name) {
     return m_option_list_find(mp_properties,name);
 }
 
--- m_option.c	(revision 18994)
+++ m_option.c	(working copy)
@@ -22,7 +22,7 @@
 //#define NO_FREE
 #endif
 
-m_option_t* m_option_list_find(m_option_t* list,char* name) {
+m_option_t* m_option_list_find(m_option_t* list,const char* name) {
   int i;
 
   for(i = 0 ; list[i].name ; i++) {
--- m_option.h	(revision 18994)
+++ m_option.h	(working copy)
@@ -439,7 +439,7 @@
  *  \param name Name of the option.
  *  \return The matching option or NULL.
  */
-m_option_t* m_option_list_find(m_option_t* list,char* name);
+m_option_t* m_option_list_find(m_option_t* list,const char* name);
 
 /// Helper to parse options, see \ref m_option_type::parse.
 inline static int
--- libvo/vo_caca.c	(revision 18994)
+++ libvo/vo_caca.c	(working copy)
@@ -67,7 +67,7 @@
 static int osdx = 0, osdy = 0;
 static int posbary = 2;
 
-static void osdmessage(int duration, char *fmt, ...)
+static void osdmessage(int duration, const char *fmt, ...)
 {
     /*
      * for outputting a centered string at the bottom
@@ -87,7 +87,7 @@
     posbar[0] = '\0';
 }
 
-static void osdpercent(int duration, int min, int max, int val, char *desc, char *unit)
+static void osdpercent(int duration, int min, int max, int val, const char *desc, const char *unit)
 {
     /*
      * prints a bar for setting values
--- libmpdemux/demux_ogg.c	(revision 18994)
+++ libmpdemux/demux_ogg.c	(working copy)
@@ -441,7 +441,7 @@
 }
 
 // check if clang has substring from comma separated langlist
-static int demux_ogg_check_lang(char *clang, char *langlist)
+static int demux_ogg_check_lang(const char *clang, char *langlist)
 {
   char *c;
 
--- libmpdemux/demuxer.c	(revision 18994)
+++ libmpdemux/demuxer.c	(working copy)
@@ -922,7 +922,7 @@
 return 1;
 }
 
-int demux_info_add(demuxer_t *demuxer, char *opt, char *param)
+int demux_info_add(demuxer_t *demuxer, const char *opt, const char *param)
 {
     char **info = demuxer->info;
     int n = 0;
--- libmpdemux/demuxer.h	(revision 18994)
+++ libmpdemux/demuxer.h	(working copy)
@@ -348,7 +348,7 @@
 
 extern int extension_parsing;
 
-int demux_info_add(demuxer_t *demuxer, char *opt, char *param);
+int demux_info_add(demuxer_t *demuxer, const char *opt, const char *param);
 char* demux_info_get(demuxer_t *demuxer, char *opt);
 int demux_info_print(demuxer_t *demuxer);
 int demux_control(demuxer_t *demuxer, int cmd, void *arg);
diff -u m_option.c m_option.c
--- m_option.c	(working copy)
+++ m_option.c	(working copy)
@@ -1196,7 +1196,7 @@
   return 0;
 }
 
-static int get_obj_param(char* opt_name,char* obj_name, m_struct_t* desc,
+static int get_obj_param(const char* opt_name,const char* obj_name, m_struct_t* desc,
 			 char* str,int* nold,int oldmax,char** dst) {
   char* eq;
   m_option_t* opt;
@@ -1249,7 +1249,7 @@
   return 1;
 }
 
-static int get_obj_params(char* opt_name, char* name,char* params,
+static int get_obj_params(const char* opt_name, const char* name,char* params,
 			  m_struct_t* desc,char separator, char*** _ret) {
   int n = 0,nold = 0, nopts,r;
   char* ptr,*last_ptr = params;


More information about the MPlayer-dev-eng mailing list