[MPlayer-dev-eng] [PATCH] new libvo driver: vo_ivtv [ask for review]

[Diego Biurrun]

On Tue, Jul 11, 2006 at 09:24:36PM +0200, Benjamin Zores wrote:
> On Tue, 11 Jul 2006 10:16:13 +0200
> Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> 
> > Ok, end of very quick surfacial review.
> 
> Attached a revised patch with all your comments taken into account.
> It is much simpler now. If it's ok for everyone, i'm gonna commit it on tomorrow.
> 
> --- libvo/vo_ivtv.c	(r??vision 0)
> +++ libvo/vo_ivtv.c	(r??vision 0)
> +
> +static uint32_t
> +ivtv_reset (int blank_screen)
> +{
> + 
> +  while (ioctl (ivtv_fd, IVTV_IOC_S_STOP_DECODE, &sd) < 0)
> +  {
> +    if (errno != EBUSY)
> +    {
> +      mp_msg (MSGT_VO, MSGL_ERR,
> +              "IVTV_IOC_STOP_DECODE: %s\n", strerror (errno));
> +      return 1;
> +    }
> +  }

Well, it's your code of course, but somehow I prefer putting function
type and name on one line as well as keeping the opening { on the same
line as if and while constructs.  It makes the code more compact.  It's
your decision.  I just looked over it superficially, all I found was
some trailing whitespace, IOW just some very minor nits..

> --- configure	(r??vision 19017)
> +++ configure	(copie de travail)
> @@ -4708,6 +4712,33 @@
>  
> +  if test "$_mp1e" = auto ; then
> +    # we don't need mp1e
> +    _mp1e=no

Heh, mp1e..  Does this thing still work nowadays?  I thought it was
looong obsolete..

Diego