[MPlayer-dev-eng] [PATCH] new libvo driver: vo_ivtv [ask for review]

[Benjamin Zores]

>> +static char ivtvbuf[262144]; /* 256 kB */
>
> IMHO write it as 256 * 1024 and get rid of the comment.

ok, fine by me.

>> +  if (arg)
>> +  {
>> +    if (!strncmp (arg, VO_IVTV_SUBOPTION_HELP,
>> +                  strlen (VO_IVTV_SUBOPTION_HELP)))
>> +    {
>
> I'd prefer if you could use the suboption parser as e.g. vo_gl does.

wasn't aware of that and it'll for sure be better
(and it would have saved me time for writing this small parser).

>> +  printf ("Out: %d\n", out);
>
> hmmm left-over debugging code?

exactly.

> Hmmm... I always supposed the data from the draw frame must stay valid
> until after the flip. In that case you could save the memcpy and write
> the data from the buffer directly. Did you try that?

ok, i'll have a try, we'll see.

> Ok, end of very quick surfacial review.

thx for it (there's no tricky parts in this vo anyhow).

Ben