[MPlayer-dev-eng] [PATCH] Disable vo_macosx on machines without QuartzExtreme

[Chris Zubrzycki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Jul 9, 2006, at 4:53 PM, Nicolas Plourde wrote:

>
> On 9-Jul-06, at 11:54 AM, Diego Biurrun wrote:
>
>> On Sat, Jul 08, 2006 at 09:52:39PM -0700, Tim Wojtulewicz wrote:
>>> This patch causes vo_macosx to not be built on machines that don't
>>> support OpenGL acceleration in CoreGraphics (i.e.  
>>> QuartzExtreme).  By
>>> default, those machines should only build vo_quartz since vo_macosx
>>> just displays a black video window.
>>>
>>> The only thing I don't like is having to hardcode the path in there
>>> for linking against Framework, but I don't know of any way to detect
>>> where that Framework is from the command line.
>>
>> No opinion on this patch, Nicolas?
>>
>
> I dont like this patch. I would rather have 2 rendering path in  
> vo_macosx and detect CoreVideo support at runtime.

I agree. Mac users are much likely to switch binaries around on  
different machines. Having a pretty important feature not built at  
all because your build machine might have an old video card is just  
bad. It's not like we are interacting directly with a certain cars,  
just using features the OS provides us with. Many apps detect  
CoreVideo support at runtime, so can mplayer.

- -chris zubrzycki
- - --
PGP public key: http://homepage.mac.com/beren/publickey.txt
ID: 0xA2ABC070
Fingerprint: 26B0 BA6B A409 FA83 42B3  1688 FBF9 8232 A2AB C070
========================================================

Remember: it's a "Microsoft virus", not an "email virus",
a "Microsoft worm", not a "computer worm".



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (Darwin)
Comment: Please sign reply-http://www.gnupg.org

iEYEARECAAYFAkSyVCwACgkQ+/mCMqKrwHDzlgCg1G++Tw59nD5on7QHQ/24NXJC
9OoAn0uPTwHMe0h7gr2Dyj/jbR3zYHJS
=ILjP
-----END PGP SIGNATURE-----