[MPlayer-dev-eng] [PATCH] bugfix for latest mp3lib/dct64_3dnow.c saturation patch

Guillaume POIRIER poirierg at gmail.com
Sat Jul 8 14:23:05 CEST 2006


Hi

On 7/8/06, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> Hi,
>
> 2006/7/8, Rich Felker <dalias at aerifal.cx>:
> > On Sat, Jul 08, 2006 at 03:13:46AM +0200, Jesus Sanchez wrote:
> > > With the patch applied on June 21 to mp3lib/dct64_3dnow.c (SVN
> > > revision 18837), mp3 files sound distorted on my K-6 machine.
> > >
> > > Attached is a patch which fixes a couple of errors I have found on the
> > > previous patch. With these fixes, mp3 files sound ok on my machine.
> > >
> > > Jesús
> >
> > > Index: dct64_3dnow.c
> > > ===================================================================
> > > --- dct64_3dnow.c     (revision 18943)
> > > +++ dct64_3dnow.c     (working copy)
> > > @@ -835,7 +835,7 @@
> > >  "    pfadd  %%mm4, %%mm3\n\t"
> > >  "    pf2id  %%mm0, %%mm1\n\t"
> > >  "    pf2id  %%mm3, %%mm3\n\t"
> > > -"    packssdw %%mm0, %%mm0\n\t"
> > > +"    packssdw %%mm1, %%mm1\n\t"
> > >  "    packssdw %%mm3, %%mm3\n\t"
> > >  "    pfadd  88(%%edx), %%mm5\n\t"
> > >  "    movd   %%mm1, %%eax\n\t"
> > > @@ -856,7 +856,7 @@
> > >  "    movd   %%mm0, %%eax\n\t"
> > >  "    pfadd  68(%%edx), %%mm6\n\t"
> > >  "    movw   %%ax, 320(%%edi)\n\t"
> > > -"    shr    $16, %%eax\n\t"
> > > +"    shrl   $16, %%eax\n\t"
> >
> > This is cosmetic only.
> >
>
> Ignore this single line the patch works correctly.

I can't test it, so I'm gonna trust you on this,
Applied, thanks,

Guillaume

-- 
"Bald guys never have a bad hair day."



More information about the MPlayer-dev-eng mailing list