[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Uoti Urpala]

On Fri, 2006-07-07 at 21:50 +0400, Evgeniy Stepanov wrote:
> On Friday 07 July 2006 18:58, Uoti Urpala wrote:
> > Feeding the timestamps to the filter chain is the problematic part;
> > feeding them broke encoding with lavc earlier, but those weren't exactly
> > the same ones then (they were from the muxer, the patch uses
> > sh_video->pts).
> 
> I've tried encoding short clips recently and didn't experience any problems.
> What is the exact problem and what can be done to fix it ? Is it somehow 
> related to your "--correct-pts" patch ?

The cause of the previous problem was that mencoder was feeding bad
timestamps into the filter chain and the lavc encoder choked on those.
Without any timestamps it assumes a constant framerate and mostly works.
To fully fix the timestamp handling would require several changes in
mencoder, and also (for "-ovc copy" at least) in the built-in demuxers.
My "-correct-pts" patch is not directly related; it improves video pts
handling in mplayer, but I haven't fixed anything in mencoder so far.