[MPlayer-dev-eng] [PATCH] better mplayer vs. gmplayer detection
Ivan Kalvachev
ikalvachev at gmail.com
Fri Jul 7 20:08:34 CEST 2006
2006/7/7, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> the attached patch changes the check to only search for "gmplayer" in
> the basename. Advantages: works under windows and also works with e.g.
> gmplayer_old, useful when keeping old versions around.
> This also means that people unsing windows will have to rename/copy
> mplayer to gmplayer to get the gui, but I find this to be preferable
> since it is consistent with the Linux version, and also try playing a
> file named test-slave.avi with the current version...
> Unless there are objections I will apply tomorrow.
use_gui is defined only when HAVE_NEW_GUI is defined.
I guess your patch would break no-gui compilation.
The rest seems ok for me.
BTW what was the reason to disable -gui command line option?
More information about the MPlayer-dev-eng
mailing list