[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Friday 07 July 2006 18:58, Uoti Urpala wrote:
> IIRC linking failed when I tried to apply the other patches without that
> one earlier because some variables were defined identically in mplayer.c
> and mencoder.c and were referred to in other object files that were
> linked in both binaries. There are a few alternatives:
> 1) Apply the mencoder patch too as is. Might or might not break things.
> Feeding the timestamps to the filter chain is the problematic part;
> feeding them broke encoding with lavc earlier, but those weren't exactly
> the same ones then (they were from the muxer, the patch uses
> sh_video->pts).

I've tried encoding short clips recently and didn't experience any problems.
What is the exact problem and what can be done to fix it ? Is it somehow 
related to your "--correct-pts" patch ?

> 2) Apply the mencoder patch otherwise but leave out the timestamps,
> doesn't break things but leaves the added code useless for now as the
> filter won't work under mencoder.
> 3) Add only the variable definitions to mencoder.c but leave out the
> rest of the patch.
> 4) Move the needed variable definitions to some other file that gets
> linked to both the mplayer and mencoder binaries.
>
> I'm currently not sure which choice would be best and probably won't try
> to investigate it further during the next few hours.

I prefer the 3rd option, along with moving ass_enabled to ass_mp.c.