[MPlayer-dev-eng] [PATCH] Choose keyframe for edits in MOV demuxer

[Diego Biurrun]

On Mon, Jul 03, 2006 at 03:54:20PM -0400, John Koleszar wrote:
> Linked below are two samples that play incorrectly using the mplayer MOV
> demuxer. Looks like they have an edit list where the starting frame isn't a
> keyframe, with predictable results. (ie, frame 0 is a KF, edit list says start
> at pts 200, which is not a KF). Attached patch changes the behavior for choosing
> the starting frame of an edit to the closest prior keyframe, if the stream has
> keyframes. Otherwise, the current behavior (frame with closest pts) is used.
> Probably a bit of a hack, but it seems like a sane way to try to recover from a
> malformed file.

BTW, the samples work fine with libavformat...

> I don't know if this is acceptable as a general case solution or not. It does
> fix these two samples and I haven't been able to identify any regressions. Other
> suggestions welcome.
> 
> Samples:
> ftp://opensource:opensource@ftp.on2.com/mov_edl_kf_fix_1.mp4
> ftp://opensource:opensource@ftp.on2.com/mov_edl_kf_fix_2.mp4

Moved to

http://samples.mplayerhq.hu/mov/editlist/

The patch works fine on all samples I tried.  Any objections or comments
on it?

Diego