[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Moritz Bunkus]

Hey,

On Monday 03 July 2006 16:56, Dominik 'Rathann' Mierzejewski wrote:

> I've been using this patch for a while now with little or no problems at
> all, so I'm going to apply 1-5 soon if nobody objects. Hopefully after
> some comments from Moritz on demux_mkv changes.

The demux_mkv changes look very good. Just a minor nitpick: If the
Matroska file contains attached fonts but no actual data (meaning just
the name and/or MIME type, but not the actual font data, data == NULL ||
data_size == 0) then such an entry should be discarded and not handed
over to ass_process_font. Yeah, such files would be broken, but that's
no reason to have them break mplayer, too ;)

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060705/0d602e94/attachment.pgp>