[MPlayer-dev-eng] [PATCH] ggi page flipping and extra keybindings

[Reimar Doeffinger]

Hello,
On Mon, Jul 03, 2006 at 01:04:06AM -0400, spdepagn at ncsu.edu wrote:
> @@ -318,6 +327,11 @@
>  
>      ggi_conf.flushregion.x1 = ggi_conf.flushregion.x2 = -1;
>      ggi_conf.flushregion.y1 = ggi_conf.flushregion.y2 = -1;
> +
> +    static int current_frame;

Mixing code and declarations will break on gcc 2.95

> +    ggiSetDisplayFrame(ggi_conf.vis, current_frame);
> +    ggiSetWriteFrame(ggi_conf.vis, current_frame);
> +    current_frame = !current_frame;

Hmm.. does this really work correctly if we allocated only one frame?

> +                case GIIUC_1:
> +                    mplayer_put_key('1');
> +                    break;
> +                case GIIUC_2:
> +                    mplayer_put_key('2');
> +                    break;
[...]

Isn't there a way to catch e.g. all numbers without an extra case for
each?

Greetings,
Reimar Doeffinger