[MPlayer-dev-eng] [PATCH] dvdnav - partial REVIEW

[Nico Sabbi]

Ötvös Attila wrote:

>  
>
>Hi All!
>
>I modify:
>
>- fixed mute bug
>- fixed xvidix yv12 bug
>- implemented use ffmpeg codec
>- remove old dvdnav code in mplayer.c
>- covert all dvdnav functions and dvdnav_priv access to stream_control() in 
>mplayer.c
>  
>

sorry to say it, but this is nonsense: stream_control() functions should 
implement only
what belongs to the stream layer, so everything that is related to user 
input, menu and
subtitles had better be invoked by a direct function call.
The CTRLs that are related to time_length, eof, lockseek (is it really 
needed?) are ok,
the others that are related to language selection are acceptable only if 
called by the demuxer
(I mean that demuxer_control() should call stream_control());
all the rest can be implemented in dvdnav_stream.c but not as 
stream_control() implementation.

>- new parameters: -dvdnav-still-repeat
>- updated current SVN version
>
>If mplayer works with "-dvdnav-still-repeat 0" then can use external libdvdnav 
>lib.
>
>  
>

please, synchronize your tree to mplayer svn.
I'd like to import your code -except libmpdvdnav, of course:) -, so what 
we need now is:
- first of all getting rid of your stream_dvdnav.c: from now on patch 
dvdnav_stream.c, please
- fix in this file the stream code that is still wrong (someone reported 
that occasionaly some titleset
can't be played (while(1) syndrome)
- if you have some better seeking code post it
- add the functions that you need for the menu code

all of the above without cosmetics and in small and indipendent patches, 
please :)

Thanks,

    Nico