[MPlayer-dev-eng] [PATCH] ggi osd support corrected, and page flipping added
spdepagn at ncsu.edu
spdepagn at ncsu.edu
Sun Jul 2 11:19:37 CEST 2006
> 2. If I understand your code correctly you are coping the drawn area
> in local buffer, draw subtitles and then put it back in the buffer.
> Somehow I don't think this is very optimal...
>
> (if we assume that ggi access directly video memory, then we know that
> old pci cards and all agp cards are much faster on writing to video
> memory than reading from it).
You are correct, I have done more extensive testing, and I think that I
should remove the osd code as it can be done faster with -vf expand=::::1
I was able to see a difference between the two which is no good, I saw a
difference with adding page flipping as well, but in this case it was
better.
I think the page flipping is still useful as well as extra keybindings.
I will wait for other opinions then submit a patch without the osd code.
Thanks.
Sean D'Epagnier
More information about the MPlayer-dev-eng
mailing list