[MPlayer-dev-eng] mencoder and freetype

[Ivan Kalvachev]

2006/7/1, Ivan Kalvachev <ikalvachev at gmail.com>:
> 2006/7/1, Chris Roccati <roccati at pobox.com>:
> >
> > On 1 Jul 2006, at 16:13 , Ivan Kalvachev wrote:
> >
> > > 2006/7/1, Chris Roccati <roccati at pobox.com>:
> > >> Hello,
> > >> some recent change in the SVN has imposed to mcoder a dependence on
> > >> freetype: instead of using libvo/libvo.a, mencoder directly depends
> > >> on libvo/font_load_ft.c (etc) causing the build to fail if freetype
> > >> is disabled or not available. Is this an accident or a design choice?
> >
> > > Many people use mencoder to embed subtitles.
> >
> > Many people do not. Making mencoder unbuildable without FreeType on
> > this basis does not sound a wise choice.
> >
> > > It is done by "export" filter.
> > > Rejected.
> >
> > As the subject didn't say [PATCH] this wasn't a patch proposal: Given
> > the fact that just a few revisions ago this didn't happen it looked
> > like it was some kind of mistake.
>
> When you have real fix for the bug you are welcome to send it here.
> Until then, use the proper channels to send proper bug report.

OK, sorry, I was a little too harsh.

Including libvo.a is a little overkill, it is reasonably big and it
contains a lot of code that doesn't belong to mencoder.

The right fix is to dublicate libvo/Makefile behaviour and use

ifeq ($(FREETYPE),yes)
endif

to conditionaly include font_load_ft

I guess this is Diego domain.

BTW he is the one who broke the compilation with commit #18869
"Move conditional FreeType support compilation to the build system."