[MPlayer-dev-eng] [PATCH] configure libav* with pkg-config

[Nico Sabbi]

Diego Biurrun wrote:

>On Sun, Jan 29, 2006 at 01:20:57PM +0100, Nico Sabbi wrote:
>  
>
>>This patch configures mplayer's support for shared libav* trying to use
>>pkg-config before trying to use the plain -lavcodec -lavformat.
>>
>>This *should* permit to use certain features of lavc and lavf relied
>>to wrappers (such as xvid rc strategy, fancy formats, etc. that at the
>>moment I'm trying).
>>    
>>
>
>They don't work ATM?
>
>  
>

no, take xvid_rc: it works only if --enable-xvid is specified during 
ffmpeg's configuration,
but if you do mencoder may fail to link without this patch

>>Please, review.
>>    
>>
>
>Here you are...
>  
>
>>-  if cc_check -lavcodec $_ld_lm ; then
>>+  _libavcodec_pkg_incs=`pkg-config --cflags libavcodec`
>>+  _libavcodec_pkg_libs=`pkg-config --libs libavcodec`
>>    
>>
>
>Please name the variables consistently, the other pkg-config checks use
>_inc_foo, _ld_foo.
>  
>

ok

>  
>
>>+  if cc_check $_libavcodec_pkg_incs $_libavcodec_pkg_libs ; then
>>+    _libavcodec_so=yes
>>+    _res_comment="using libavcodec.so with pkg-config, but static libavcodec is recommended"
>>    
>>
>
>That's excessive detail IMO, it's not necessary to know if it was
>detected by pkg-config or not.  Just leave it out.
>
>  
>

are you sure? if users report bugs we have this information  at hand 
without having
to dig in configure.log