[MPlayer-dev-eng] Re: [PATCH] Profiles support for MEncoder - Upgrade

[Danny - liste]

Alban Bedel wrote:

> Sorry for jumping in a bit late. The patch look good, but i must say i don't
> like very much the idea of having yet another parser. For the devs it's
> one more to maintain and for the users it's one more sligthly different
> config file format.
>   

    You can use the config file sintax and it work, the one listed in 
the man page is, IMHO, cleaner.

    Also the fact that I put only one lavcopt on every line is a choise 
made to simplify the fact that you can comment one option.

    You can put a profile with all the lavcopts that affect mpeg4 
encoding commented (with a #) and test it simply adding or deleting a 
single #.

> So i'm suggestinge something very similar but extending the config file
> parser instead. With the attached patch you can add some "sections" to
> your config file to define some profile. For example:
>
> [mpeg4]
> ovc=lavc=1
> lavcopts=vcodec=mpeg4:vbitrate=1200
>
> [filter640]
> vf=spp,scale=640:480
>
> Then use with: mencoder -profile mpeg4,filter640 file.avi
>
> 	Albeu
>   

    In the end what is important is to have the feature in the code. 
Obviusly I prefer mine ;)

    I try to let the user use the style he/she likes, being extremely 
permissive on the sintax.

    Also, being a module not in the parser it's may be more simple to 
expand it: I would like to have a profile in which, as a parameter, you 
put the bitrate you like (mencoder -profile mpeg4(1200),ac3(224) file.avi)

    For the fact to have another parser I agree with you: it's better to 
have only one parser (and I'm talking also about the suboptions parser).

    Maybe it's time to make a libmpparse with, documented, the various 
function you can use ?

       Daniele Forghieri