[MPlayer-dev-eng] MPLAYER_VERBOSE environment variable?

[Diego Biurrun]

On Wed, Jan 18, 2006 at 01:55:08PM +0200, Ivan Kalvachev wrote:
> 2006/1/17, Oded Shimon <ods15 at ods15.dyndns.org>:
> > On Tue, Jan 17, 2006 at 03:07:52AM -0500, Chuck Blake wrote:
> > > --- mp_msg.c  7 Dec 2005 05:12:07 -0000       1.31
> > > +++ mp_msg.c  17 Jan 2006 07:30:44 -0000
> > > @@ -26,6 +26,9 @@
> > >
> > >  void mp_msg_init(){
> > >      int i;
> > > +    char *env = getenv("MPLAYER_VERBOSE");
> > > +    if (env)
> > > +        verbose = atoi(env);
> >
> > I like this, I'm in favor of committing. Is there any portability issues?
> > can I commit?..
> >
> > - ods15
> 
> I don't like it.
> 
> You can always set verbose option in the ~/.mplayer/config file per
> user basis or in global config file. You can override it on invocation
> basis with command line.

Read the rationale for the patch again, you misunderstand.

Diego