[MPlayer-dev-eng] MPlayer package for Debian

[Dominik 'Rathann' Mierzejewski]

On Monday, 16 January 2006 at 03:45, Diego Biurrun wrote:
[...]
> BTW, it's time to evaluate Christian Marillat's packages.  He just
> released a new CVS snapshot that features almost all our suggestions.  I
> only had a quick glance now, but they are much improved.  They even
> feature a separately packaged skin
[...]

Yes, they do and yes, they are much improved. However...

1.I still don't like the idea of building -i586 packages which won't run
  on a Pentium CPU
2.MPlayer version string (mplayer -v) is still not modified appropriately
3.I still don't like the patch below

+-#define MSGTR_CompiledWithRuntimeDetection "Compiled with runtime CPU detection - WARNING - this is not optimal!\nTo get best performance, recompile MPlayer with --disable-runtime-cpudetection.\n"
++#define MSGTR_CompiledWithRuntimeDetection "Compiled for Debian\n"

4.Many potentially interesting patches have never been submitted to us,
  i.e. 05_heap_overflow.dpatch and others
5.Old config file (which mentions for example -aop list) is still
  packaged instead of the one included in current MPlayer CVS
6.config.h and config.mak files are still packaged

I'm very sorry to say this, but I still can't recommend Christian's
packages to the general public.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"