[MPlayer-dev-eng] [PATCH] support for libXvMCW wrapper library

[Dominik 'Rathann' Mierzejewski]

On Monday, 12 September 2005 at 01:14, Dominik 'Rathann' Mierzejewski wrote:
> On Monday, 12 September 2005 at 00:56, Guillaume POIRIER wrote:
> > Hi,
> > 
> > On 8/21/05, Wes Shull <wes.shull at gmail.com> wrote:
> > > libXvMCW is a wrapper which dlopens a proper libXvMC at runtime (which
> > > one it loads is configurable); it eliminates the need to link directly
> > > against a hardware-specific xvmc lib to support it.
> > > 
> > > The library originated in the Unichrome driver project (
> > > http://unichrome.sourceforge.net/ ) but is useful for nvidia, etc.
> > > too.  It's in ATrpms, probably other places too.
> > > 
> > > Attached is a pretty simple mostly cut&paste patch to enable its use
> > > with mplayer.  It adds an --enable-xvmcw (and --disable-xvmcw) option,
> > > which must be used in conjunction with --enable-xvmc.
> > > 
> > > The patch is directly against configure, from today's (anon) cvs,
> > > which feels very wrong to me--it should be against configure.in.
> > > Except I can't find that.
> > > 
> > > This is my first patch submission to mplayer.  Flame away ;-)
> > 
> > Do you have a new patch available that features Dominik's suggestions?
> 
> And Ivan's.

As it turns out, there's no need for your patch, Wes. All the support is
already in place, we just need to make it autodetected and set the
defaults, i.e. like the attached patch.

I've tested it as far as the compilation goes, because I have no
XvMC-capable cards at home, but it should work, as long as XvMCW works.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
-------------- next part --------------
--- MPlayer-20060114/configure.xvmc	2006-01-15 20:12:22.000000000 +0100
+++ MPlayer-20060114/configure	2006-01-15 20:43:05.000000000 +0100
@@ -291,7 +291,7 @@
   --enable-xmga          build with mga_vid X Window support
                          (check for X & /dev/mga_vid) [autodetect]
   --enable-xv            build with Xv render support for X 4.x [autodetect]
-  --enable-xvmc          build with XvMC acceleration for X 4.x [disable]
+  --enable-xvmc          build with XvMC acceleration for X 4.x [autodetect]
   --enable-vm            build with XF86VidMode support for X11 [autodetect]
   --enable-xinerama      build with Xinerama support for X11 [autodetect]
   --enable-x11           build with X11 render support [autodetect]
@@ -390,7 +390,8 @@
   --with-xmmslibdir=DIR    libxmms.so.1 in DIR
   --with-cdparanoiaincdir=DIR  cdparanoia headers in DIR (*)
   --with-cdparanoialibdir=DIR  cdparanoia libraries (libcdda_*) in DIR (*)
-  --with-xvmclib=NAME      name of adapter-specific library (e.g. XvMCNVIDIA)
+  --with-xvmclib=NAME      override the name of adapter-specific library
+                           (e.g. XvMCNVIDIA, default: XvMCW)
   --with-termcaplib=NAME   name of library with termcap functionality
                            name should be given without leading "lib"
                            checks for "termcap" and "tinfo"
@@ -1450,7 +1451,7 @@
 cc_check -pipe && _pipe="-pipe" && echores "yes" || echores "no"
 
 _prefix="/usr/local"
-_xvmclib="XvMCNVIDIA"
+_xvmclib="XvMCW"
 
 # GOTCHA: the variables below defines the default behavior for autodetection
 # and have - unless stated otherwise - at least 2 states : yes no
@@ -1469,7 +1470,7 @@
 _x11=auto
 _dga=auto	# 1 2 no auto
 _xv=auto
-_xvmc=no  #auto when complete
+_xvmc=auto
 _sdl=auto
 _directx=auto
 _win32waveout=auto