[MPlayer-dev-eng] [PATCH] darwin dvd selection fix

Emanuele Giaquinta emanuele.giaquinta at gmail.com
Mon Jan 9 16:57:21 CET 2006


On 1/9/06, Diego Biurrun <diego at biurrun.de> wrote:
> libdvdread is being worked on again?  Wow, that's great news.  Do you
> know if they have incorporated our patches or would be interested in
> accepting them?

They have already incorporated most of them, look here:

http://lists.berlios.de/pipermail/ogle-devel/2005-September/000665.html

> Maybe it would be better to upgrade to their CVS version or the next
> release if it is going to appear soon.

I agree, but then this code must be disabled when linking to an
external libdvdread, except for the upcoming one of course.

> > It fixes the case when the dvd drive is associated to a rdiski, and
> > a rdiskj exists with j < i; without this patch the demuxer will try
> > to open rdiskj, since DVDOpen returns a valid dvdreader_t for it, and
> > will fail after the call to ifoOpen.
>
> Does it still work the other way around?  When the dvd drive is associated
> to a rdiski, and a rdiskj exists with j > i?

If it tries to open the file associated to the dvd drive first, it
obviously works.

> P.S.: Is this the same patch you submitted some time ago?

No, it's a different one.




More information about the MPlayer-dev-eng mailing list