[MPlayer-dev-eng] [PATCH] support for shared libavformat

[Nico Sabbi]

Diego Biurrun wrote:

>On Sun, Jan 08, 2006 at 11:39:35PM +0100, Nico Sabbi wrote:
>  
>
>>Diego Biurrun wrote:
>>
>>    
>>
>>>In any case it should be consistent.  Maybe you can commit my suggestion
>>>first and then we can discuss changing lavc/lavf together.  How about
>>>that?
>>>      
>>>
>>new, more consistent, patch attached. Please, review
>>
>>@@ -1805,7 +1806,7 @@
>>   --enable-codec=*)	_libavcodecs="$_libavcodecs `echo $ac_option | cut -d '=' -f 2`" ;;
>>   --disable-codec=*)	_libavcodecs=`echo $_libavcodecs | sed "s/\`echo $ac_option | cut -d '=' -f 2\`//g"` ;;
>>   --enable-libavformat)	_libavformat=yes;;
>>-  --disable-libavformat)	_libavformat=no	;;
>>+  --disable-libavformat)	_libavformat=no; _libavformat_so=no	;;
>>    
>>
>
>Hmm, --disable-libavcodec does not disable _libavcodec_so, this should
>behave the same way.
>
>  
>

it's broken: if you have only the external libavcodec 
--disable-libavcodec doesn't disable it
grep AVC config.mak config.h
config.mak:CONFIG_LIBAVCODEC = no
config.mak:CONFIG_LIBAVCODECSO = yes
config.h:#define USE_LIBAVCODEC 1
config.h:#define USE_LIBAVCODEC_SO 1

The attached patch that acts (and breaks) identically with libavformat, 
but let's fix it
after commit



-------------- next part --------------
A non-text attachment was scrubbed...
Name: avformat4.diff
Type: text/x-patch
Size: 7456 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060109/d2187158/attachment.bin>