[MPlayer-dev-eng] [PATCH] Implement stride support in ve_raw and vf_vo wrapper

Ivan Kalvachev ikalvachev at gmail.com
Wed Jan 4 00:47:53 CET 2006


2006/1/4, John Koleszar <jkoleszar at on2.com>:
> Ivan Kalvachev wrote:
>
> >>From the patch it looks like you get everything right.
> >
> >
> After more testing, it looks like I didn't. :-(
>
> >I had some doubts about using the video system to allocate the
> >temporal buffer, but on second thought I guess it is OK.
> >
> This doesn't actually work in all cases. The model for calling
> vf_get_image is that you get get destination images by using vf->next,
> which I gather is how DR works. Since the ve's and vo's are at the end
> of the chain, there is no next filter. Since the decoder (or other
> filters) render into the ve's context, the ve can't allocate an image in
> it's own context.

It looks like i have not been on my self. Now on second look i saw
that you actually change 2 files. There is absolutlely no need to
change vf_vo.c . AFAI can see ve_raw doesn't have draw_frame() and
AFAIK ve_* doesn't use vo_ interface.

When vo/vf cannot get_image it must return NULL, then vo will allocate
the image.
I must check to see in what conext this image is stored.... (i think
it should be in the caller, but who knows).

will look at it when i can...




More information about the MPlayer-dev-eng mailing list