[MPlayer-dev-eng] [PATCH] Warning fixes for mplayer.c

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 20 December 2005 at 19:32, The Wanderer wrote:
> On 12/19/2005 05:21 AM, Diego Biurrun wrote:
> 
> >On Mon, Dec 19, 2005 at 11:18:03AM +0100, Dominik 'Rathann'
> >Mierzejewski wrote:
> >
> >>On Saturday, 17 December 2005 at 20:52, Oded Shimon wrote:
> >>
> >>>warning fixes for mplayer.c, mostly printf '%d' for 'long' type
> >>>stuff,
> >>
> >>I've already submitted a patch fixing all of them, not only in
> >>mplayer.c.
> >
> >But did you commit it?  Somebody please do...
> 
> It was submitted on November 27th, and has not been committed. However,
> there was enough "this should probably be done differently" discussion
> in response to the patch that I'm reluctant to commit it as-is.
> 
> (I'm 'way too far behind on the patch backlog, even just in my own
> records much less the ones I inherited - which is partly because I
> suspect that flooding the list with too many "comments?" posts would
> just mean none of them would get responses... and the current backlog of
> "comments?" posts is getting long enough as it is.)

For the record, I'm keeping it up-to-date with current CVS in my tree, so
if anyone wants a current version, just say so and I'll repost.

> Speaking of compiler warnings, I'm recently getting varyingly minor
> floods of "pointer targets in passing argument # of function_name differ
> in signedness" warnings throughout the code. I suspect that this is
> because of a recent 'upgrade' to gcc, which I didn't consciously notice
> I was making (part of a mass "clean up and clean out my installed
> packages" project); I'm currently compiling with a gcc 4.0.3 prerelease
> from the first of the month. Is it worth trying to modify the code to
> remove these warnings (not that I have the faintest idea how that might
> be done), and if not, to what version should I most likely 'downgrade'?

No need to downgrade. Warnings are usually harmless and sometimes indicate
compiler bug or compiler authors' overzealousness. I'm getting the same
warnings and I'll try get rid of them at some point in the future.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"