[MPlayer-dev-eng] [PATCH] dvdnav

[Benjamin Zores]

On Thu, 23 Feb 2006 21:04:01 +0100
Ötvös Attila <oattila at chello.hu> wrote:

> I fixed the other streamN of spu button but the "dual layer" spu wasn't 
> implemented.
> I updated with current CVS.
> 
> http://dcxx.fw.hu/

By the way, I had a deeper look at the patch itself today.
In fact I've did a customized (with your patch) version of GeeXboX Live-CD
(so if by the way someone's here want to test this patch quickly with or without dev skill,
just ask for the URL).
I'm making some of our users test it in order to provide you more and more feedback.

But when doing this I've found that you've done many changes to MPlayer
(changed the prototypes of strem_open or demux_open, don't remember which ..)
but especially you've removed libpostprocess build !

Is there any special reason to do that, because :
- it fails to build/link without it (with --enable-libavcodec at least) : i thought it was MPlayer's CVS but it's introduced by your patch.
- you have no reason to do that as it works pretty fine with it
- it's anyway non acceptable.

Besides that, I know that the patch is far from being complete and support all DVDs but
maybe some MPlayer developer can start having a deeper look at it.

Some parts probably can be commited and we anyhow to do it pieces by pieces if we want DVDNav support to be restored some day (and it begans to be hard to port patch each time as there are already a huge amount of code and changes).

Ben

-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama