[MPlayer-dev-eng] [PATCH] directfb -> pkg-config

[Enrico Weigelt]

* Ivan Kalvachev <ikalvachev at gmail.com> schrieb:

<snip>

> The only problem if we try to detect library when pkg-config fails
> is that the configure would be a little bit bigger and slower.
> I don't see this as problem as long as there are cases where
> pkg-config could fail and detection would work.

In other words, you suggest an multi-step detection. This is okay,
if it can be easily disabled, ie. "--disable-autodetects" or maybe 
"--pkg-config-only" prevents running the builtin tests and only
relying on pkg-config. This is sometimes necessary (ie. in sysroot
environments) to prevent false-positives. 

For example, imagine we check for directfb by looking for 
/usr/include/directfb.h. The host system has directfb installed,
but the (sysroot'ed) build environment has not. You can easily 
see, that we get an false positive, which ends up in an broken 
build. (the compiler won't find direcfb.h, since its outside
of its sysroot).


IMHO the best solution is to simply write an own pkg-config 
style script, which handles the packages required by mplayer 
and is called if $PKG_CONFIG is not set.


cu
-- 
"*Who am I*? I am Susan Ivanova, Commander, daughter of Andrei and Sophie
  Ivanova. I am the right hand of vengeance, and the boot that is going 
  to kick your sorry ass all the way back to Earth... I am Death Incarnate, 
  and the last living thing that you are ever going to see. God sent me."
                                                       -- Cmdr. Ivanova