[MPlayer-dev-eng] [PATCH] ve_lavc cosmetics: empire strikes back

Robert Swain robert.swain at gmail.com
Sun Feb 19 11:37:36 CET 2006


On Sunday 19 February 2006 09:59, The Wanderer wrote:
> Diego Biurrun wrote:
> > On Sun, Feb 19, 2006 at 01:06:09AM -0500, The Wanderer wrote:
> >> Robert Swain wrote:
> >>> I disagree with the last point as there is a mix of tabs and
> >>> spaces, and the space indentation is also messed up. See the
> >>> patches.
> >>
> >> I believe that this qualifies as a cosmetic change, and so even if
> >> desirable (which tab policy would seem to indicate that it is)
> >> would have to be done in a separate commit.
> >
> > They are talking about a cosmetics-only patch.
>
> ...oof. Sorry - I got things turned around in my head, I thought this
> was a functional change. (I don't know how I missed the bloody SUBJECT
> LINE...)

:s Sorry about the whole mess up with the reply to another thread thing. I 
couldn't remember the address off the top of my head so I replied to another 
message and changed the subject as you said. I shouldn't have assumed that 
there was nothing else under the hood such as an "in reply to" thing that 
Diego mentioned the other day. Sorry, won't happen again.

So, how does this patch look?

Rob




More information about the MPlayer-dev-eng mailing list