[MPlayer-dev-eng] FFmpeg build system integration

[Diego Biurrun]

On Tue, Feb 14, 2006 at 03:21:01PM +0200, Ivan Kalvachev wrote:
> 2006/2/14, Diego Biurrun <diego at biurrun.de>:
> > On Tue, Feb 14, 2006 at 10:24:39AM +0200, Ivan Kalvachev wrote:
> > > 2006/2/14, Diego Biurrun <diego at biurrun.de>:
> > > > As you may have noticed the MPlayer build is currently broken due to the
> > > > latest changes to the build system in FFmpeg.  Mans came up with the
> > > > simple but clever idea of putting all the common stuff from the
> > > > different libav* Makefiles into a file in the root of the src tree:
> > > > common.mak.
> > > >
> > > > While this shaves more than 150 lines from the FFmpeg Makefiles, it's a
> > > > problem for us since we need to integrate this file now in one form or
> > > > the other.  We have several options:
> > > >
> > > > * Copy common.mak to our source tree similar to the libav* dirs.
> > > > * cvs add common.mak to our source tree.
> > > > * Put all of ffmpeg in our source tree instead of just a few dirs.
> > >
> > > How about moving common.mak to libavutil ?
> >
> > That would IMO be a hack in FFmpeg to accomodate MPlayer.  We would have
> > to make changes to FFmpeg as well then.  In FFmpeg the root directory is
> > the most natural place for common.mak...
> 
> There is yet another problem with the new build system.
> It seems that FFmpeg Makefiles use $(SRC_PATH) that is of course not
> set by MPlayer configure.
> The problem is that libpostprocess cannot find the common.mak even if
> it is in mplayer main/

I know.

> Anyway, DonDiego, you are honored by 10l cola per day for deliberately
> breaking MPlayer CVS.

WTF?  Please spare me your lame jokes.  First off, it was Mans that
created and committed the patch.  Second, I won't reject a patch that
shaves more than 150 duplicate lines from the FFmpeg build system on the
grounds that it (temporarily) breaks MPlayer.  Yes, both projects are
intimately related, but decisions are still made independently.

Diego