[MPlayer-dev-eng] [patch] doublefree and misalign in dec_audio.c

[Diego Biurrun]

On Tue, Feb 14, 2006 at 10:37:32AM +0100, Luca Barbato wrote:
> Diego Biurrun wrote:
> > On Mon, Feb 13, 2006 at 08:30:21PM +0100, Luca Barbato wrote:
> >> Reimar Döffinger wrote:
> >>>> 2 the buffers aren't aligned, so some altivec/SIMD code may not behave
> >>>> correctly at random if is expecting aligned space.
> >>> Yes, that is fine with me, I'd say it should be applied.
> >> Patch reduced to just the correct lines
> > 
> > BTW, there are two more occurrences of malloc in that file.  Do they
> > have to be converted to memalign as well?
> > 
> 
> buf = malloc(buf_len);
> 
> string holding the plugin name, no simd involved I think.
> 
> 
> afs = (af_stream_t*)malloc(sizeof(af_stream_t));
> 
> it is just a struct, nobody will use it directly for simd stuff, I think
> 
> >> --- libmpcodecs/dec_audio.c	9 Feb 2006 14:07:55 -0000	1.48
> >> +++ libmpcodecs/dec_audio.c	13 Feb 2006 19:31:30 -0000
> >> @@ -251,6 +251,7 @@
> >>      if(sh_audio->afilter){
> >>  	mp_msg(MSGT_DECAUDIO,MSGL_V,"Uninit audio filters...\n");
> >>  	af_uninit(sh_audio->afilter);
> >> +	mp_msg(MSGT_DECAUDIO,MSGL_V,"Uninit audio filters... done\n");
> > 
> > I think I'll leave this out from the commit.
> 
> Right

OK, patch applied.

Thanks, this fixed a big problem on my machine...

Diego