[MPlayer-dev-eng] [PATCH] fix vo fbdev in directcolor modes
joey at nicewarrior.org
Tue Feb 14 02:16:13 CET 2006
On Mon, Feb 13, 2006 at 02:02:58AM -0500, Alan Curry wrote:
> The colormap save and restore code in vo_fbdev is broken; the caller of
> FBIOGETCMAP must allocate space for the reds, greens, and blues as well as
> for the struct that points to them. This only affects fb drivers that work in
> directcolor mode instead of truecolor mode, like radeonfb. This patch makes
> vo_fbdev work for me with radeonfb, which it didn't before.
> The patch also fixes the same problem with fbdev2, and afterward fbdev2 works
> at least some of the time (it still has some other problems)
Looks OK to me, but I no longer have an fbdev system on which to test.
All philosophy is naïve.
More information about the MPlayer-dev-eng