[MPlayer-dev-eng] [patch] doublefree and misalign in dec_audio.c

[Luca Barbato]

Reimar Döffinger wrote:
> Hi,
> On Mon, Feb 13, 2006 at 12:45:01PM +0100, Luca Barbato wrote:
>> 1 the af got freed on af_uninit so the other free is wrong.
> 
> But _that_ free is for the af_stream_t *, AFAICT af_uninit only frees
> the af_instance_t * 's

You are right, was too tired yesterday night, I'm rechecking if that
issue was just due the misalignment fixed before

> 
>> 2 the buffers aren't aligned, so some altivec/SIMD code may not behave
>> correctly at random if is expecting aligned space.
> 
> Yes, that is fine with me, I'd say it should be applied.

Good =)

lu

-- 

Luca Barbato

Gentoo/linux Developer		Gentoo/PPC Operational Leader
http://dev.gentoo.org/~lu_zero