[MPlayer-dev-eng] [patch] doublefree and misalign in dec_audio.c

Diego Biurrun diego at biurrun.de
Mon Feb 13 13:35:58 CET 2006


On Mon, Feb 13, 2006 at 12:45:01PM +0100, Luca Barbato wrote:
> Reimar at mplayerhq.hu wrote:
> > 
> > See my comment to Diego's mail.
> 
> Please point me an url, I cannot find it currently

http://mplayerhq.hu/pipermail/mplayer-advusers/2006-February/001387.html

> > I regularly use valgrind and it doesn't report anything. Can you provide
> > details when this happens??
> 
> issues:
> 
> 1 the af got freed on af_uninit so the other free is wrong.
> 
> 2 the buffers aren't aligned, so some altivec/SIMD code may not behave
> correctly at random if is expecting aligned space.

Hmm, maybe you should split the patch in two then...

Diego




More information about the MPlayer-dev-eng mailing list