[MPlayer-dev-eng] Patch to support Linux on MIPS/MIPS64
Diego Biurrun
diego at biurrun.de
Sun Feb 12 23:21:35 CET 2006
On Sun, Feb 12, 2006 at 09:32:43PM +0000, Matthew Johnson wrote:
> On Sun, 12 Feb 2006, Diego Biurrun wrote:
>
> >Try the 'linux' command instead, it is defined at the top of configure.
>
> aha, I know nothing about the mplayer build system, fair enough
>
> >You are duplicating 10 lines, this is not good. Instead you should use
> >a different command to generate the value stored in 'proc'. For Linux
> >it should be your command, for Irix the one that is already there.
>
> Yeah, good point.
>
> >I'll apply a patch that features my suggestions right away.
>
> Good, as long as it gets fixed, fine.
I'm sorry, I was unclear, what I meant to say was: Please update your
patch according to my suggestions and I'll apply it. I could try it
myself of course, but I am short of time and have no means to test it...
Thanks
Diego
More information about the MPlayer-dev-eng
mailing list