[MPlayer-dev-eng] Patches for NUT

[Oded Shimon]

On Sat, Feb 11, 2006 at 10:51:47AM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Sat, Feb 11, 2006 at 09:45:58AM +0200, Oded Shimon wrote:
> > On Sat, Feb 11, 2006 at 02:47:49AM -0500, Rich Felker wrote:
> > > On Sat, Feb 11, 2006 at 07:59:57AM +0200, Oded Shimon wrote:
> > > > > > One more issue - now that index does not mark EOF as it can appear 
> > > > > > anywhere, the index_ptr comes out of nowhere, the demuxer can even mistake 
> > > > > > it for being a frame startcode (It could even appear as a NUT startcode!).
> > > > > > So I suggest making a end_startcode before the index_ptr...
> > > > > 
> > > > > just put index_ptr into the index, right before the checksum
> > > > 
> > > > That's.. a bit odd... Will all indexes have an index_ptr? Or only the one 
> > > > at EOF?
> > > 
> > > For simplicity, all should. All copies of the index should be
> > > binary-identical anyway, so if the index_ptr is part of the index
> > > packet, it must always be there.
> > > 
> > > > Also it makes it impossible to add reserved bytes in the index.
> > > 
> > > No it doesn't. The additional space just goes before the index_ptr
> > > rather than after it.
> > 
> > Yeah I realized this after I sent the mail by looking at the spec..
> > 
> > So, how is this patch. Can I commit?
> 
> IMHO yes

Committed.
Sorry I'm so quick, I think we all agree, if anyone has any objections 
speak up...

- ods15