[MPlayer-dev-eng] [PATCH] altivec scaler performance enhancement

[Dominik 'Rathann' Mierzejewski]

On Friday, 10 February 2006 at 16:01, Michael Niedermayer wrote:
> Hi
> 
> On Fri, Feb 10, 2006 at 10:35:20AM +0100, Diego Biurrun wrote:
> > On Thu, Feb 09, 2006 at 10:12:14PM -0500, Alan Curry wrote:
> > > Michael Niedermayer writes the following:
> > > >
> > > >On Tue, Feb 07, 2006 at 05:50:56AM -0500, Alan Curry wrote:
> > > >> It would be better, I think, to just build the vectors that you're actually
> > > >> going to use. Or build them all just once and preserve them in the
> > > >> SwsContext, since they are just expanded versions of the v{Lum,Chr}Filter
> > > >> that is already in there.
> > > >
> > > >yes
> > > 
> > > This is the patch to move the v{Y,C}CoeffsBank vectors into the SwsContext,
> > > filling them in just once when the scaler is initialized, instead of building
> > > them and freeing them over and over. In my tests, it cuts CPU usage in half
> > > or better. Not just the scaler's CPU usage - the usage of the entire mplayer
> > > process! One of my tests went from being a 94% CPU hog to 33%.
> > 
> > Outstanding!  Works like a charm here, I'm seeing 30-50% performance
> > improvements.  Michael, OK to commit?
> 
> yes, after fixing the indention of the moved code

Outstanding indeed. Mention it in the ChangeLog, too, please.

R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and oppression
to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan