[MPlayer-dev-eng] Patches for NUT

Oded Shimon ods15 at ods15.dyndns.org
Fri Feb 10 11:42:58 CET 2006


On Fri, Feb 10, 2006 at 11:28:34AM +0200, Oded Shimon wrote:
> On Fri, Feb 10, 2006 at 10:58:35AM +0200, Oded Shimon wrote:
> > On Fri, Feb 10, 2006 at 02:48:23AM -0500, Rich Felker wrote:
> > > On Fri, Feb 10, 2006 at 02:34:30AM +0200, Oded Shimon wrote:
> > > > Rich suggested an implementation for compare_ts that does not require 
> > > > convert_ts or division (long 1st grade multiplication). As for convert_ts, 
> > > > it's use could be eliminated by preparing threshold in every timebase at 
> > > > init, and:
> > > > (t2 - t1 > thres)
> > > > 
> > > > Is identical to:
> > > > (t2 - thres > t1)
> > > 
> > > It's not identical because thres can't necessarily be expressed in the
> > > timebase of t2. But maybe it can be used somehow.
> > 
> > Given the implementation I showed, it is identical, this is what I hated 
> > about this threshold idea, it's very impercise, which is why now I 
> > suggest..
> > pts_threshold, per stream, from last_pts . Same idea Michael had before my 
> > suggestion, however, last_pts is _NOT_ the pts of the last frame in the 
> > same stream (which would be very far in case of subtitles), it is the 
> > last_pts CONTEXT, which is reset by syncpoints all over. So, even for 
> > subtitles, it will never be more than 1 second away or so. This won't even 
> > need an extra variable. I think it is the best solution...
> 
> crc32 and the max_pts_distance explained above. can I commit?

Committed.

- ods15




More information about the MPlayer-dev-eng mailing list