[MPlayer-dev-eng] [PATCH] img_format.h needs config.h

Alan Curry pacman at TheWorld.com
Thu Feb 9 20:56:36 CET 2006


Ivan Kalvachev writes the following:
>
>There was a recomendation to avoid recursive inclusion of header files.
>This way all .h are clearly visible in the begginging of the file.

Ah, the BSD style, in which users are burdened with the task of manually
tracking the prerequisites of the header files...

>Anyway img_format.c fixed by adding config.h in the beggining.

If that's the way you're going to fix it, there are at least 2 other places
that need the same fix. I found them by sticking a #error in the
non-WORDS_BIGENDIAN section of img_format.h and recompiling everything. They
were vf_bmovl.c and sub_cc.c - and those are just the ones that are
compilable on my machine.




More information about the MPlayer-dev-eng mailing list