[MPlayer-dev-eng] Re: [PATCH] demux_avi: instant A-V sync correction on seeking

[Corey Hickey]

Ivan Kalvachev wrote:
> Would You revert it. It seem that there are some problems and even
> users seek instructions how to retrive older version.

Done.

> Feb 08 12:12:16 <uau>   Corey changed it to be passed as a parameter
> instead, breaking stuff badly
> Feb 08 12:12:34 <uau>   nobody commented on that patch, and he
> eventually committed it (apparently without any testing...)

No, I tested, sent the patch in, waited, applied the patch to my clean
tree, tested again, and committed -- all using an older patch I had made
before I was even finished making changes. I'll send in a (hopefully)
finished patch in a minute.

The odd thing about it is that even, despite the breakage, it still
works perfectly for me, which is obviously why I didn't notice I was
using the wrong patch. I even checked with gdb just now because I was
curious what was going on. In the container-specific seeking functions
audio_delay "magically" ends up getting set to the correct value despite
 not being passed from demux_seek().

> Feb 08 12:17:56 <dalias>        well can you send an email with these findings
> Feb 08 12:17:59 <dalias>        and some cola for corey?

Send it. I'm completely out of root beer, so I won't even be tempted to
drink anything other than cola.

Sorry, folks.

-Corey