[MPlayer-dev-eng] [PATCH] RGB/BGR big-endian fixes

[Ivan Kalvachev]

2006/2/9, Alan Curry <pacman at theworld.com>:
> Diego Biurrun writes the following:
> >
> >>   mplayer -vo x11 -vf format=bgr24,scale movie.avi
> >>   mplayer -vo x11 -vf format=rgb24,scale movie.avi
> >>
> >> both produce wrong colors while vo_xv is fine.  This problem is not
> >> caused by this patch, though, it was present before.  Disabling AltiVec
> >> does not make a difference.
> >
> >I tested some more with vo_png, vo_jpeg, vo_pnm and vo_tga.  vo_tga and
> >rgb24 create a blue picture, but this occurs with and without the patch.
> >Everything else is fine.
>
> There are several non-altivec-related big-endian bugs in rgb2rgb.c and
> rgb2rgb_template.c, which probably explains these color problems. Red and
> blue can be reversed, or in a 32 bit format the 8 unused/alpha bits can be on
> the wrong side of the other 24 bits. Exactly which kind of color permutation
> you get depends on what depth your X server is running in.

We have different ABGR and BGRA formats, have you took this into account?
Maybe vo_x11 need ficxing too?